-----Original Message----- From: Richard W.M. Jones [mailto:rjones@redhat.com] Sent: Monday, March 23, 2015 9:32 PM To: Chen, Hanxiao/陈 晗霄 Cc: libguestfs@redhat.com Subject: Re: [Libguestfs] [PATCH v2] New API: btrfs-image
On Tue, Mar 17, 2015 at 02:53:35AM -0400, Chen Hanxiao wrote:
+ /* btrfs-progs will valid numtheads and choose the right one for us */ + if ((optargs_bitmask & GUESTFS_BTRFS_IMAGE_NUMTHREADS_BITMASK) + && numthreads) { + snprintf (numthreads_s, sizeof numthreads_s, "%d", numthreads); + ADD_ARG (argv, i, "-t"); + ADD_ARG (argv, i, numthreads_s); + }
Can you get rid of this, as I think it's an implementation detail. We don't need to expose the -t/threads to API users.
The patch is fine otherwise.
OK, will fixed soon. Regards, - Chen