On Tue, Mar 17, 2015 at 02:53:35AM -0400, Chen Hanxiao wrote:
+ /* btrfs-progs will valid numtheads and choose the right one for us */ + if ((optargs_bitmask & GUESTFS_BTRFS_IMAGE_NUMTHREADS_BITMASK) + && numthreads) { + snprintf (numthreads_s, sizeof numthreads_s, "%d", numthreads); + ADD_ARG (argv, i, "-t"); + ADD_ARG (argv, i, numthreads_s); + }
Can you get rid of this, as I think it's an implementation detail. We don't need to expose the -t/threads to API users. The patch is fine otherwise. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/