[PATCH Fedora libguestfs v2] Don't depend on libvirt-daemon-kvm
This gets rid of the various storage drivers. I believe we do not use type=volume, *except* on secrets. Rich.
libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter. There are no Fedora TCG-only arches, so drop the conditional section. --- libguestfs.spec | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libguestfs.spec b/libguestfs.spec index 0d32ef0..872d430 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -211,12 +211,10 @@ Requires: fuse # For core disk-create API. Requires: /usr/bin/qemu-img -# For libvirt backend. -%ifarch %{ix86} x86_64 %{arm} aarch64 -Requires: libvirt-daemon-kvm >= 0.10.2-3 -%else -Requires: libvirt-daemon-qemu >= 0.10.2-3 -%endif +# For qemu direct and libvirt backends. +Requires: qemu-kvm-core +Requires: libvirt-daemon-driver-qemu +Requires: libvirt-daemon-driver-secret Recommends: libvirt-daemon-config-network Requires: selinux-policy >= 3.11.1-63 -- 2.24.1
On Friday, 10 January 2020 15:59:35 CET Richard W.M. Jones wrote:
libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter.
There are no Fedora TCG-only arches, so drop the conditional section. --- libguestfs.spec | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/libguestfs.spec b/libguestfs.spec index 0d32ef0..872d430 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -211,12 +211,10 @@ Requires: fuse # For core disk-create API. Requires: /usr/bin/qemu-img
-# For libvirt backend. -%ifarch %{ix86} x86_64 %{arm} aarch64 -Requires: libvirt-daemon-kvm >= 0.10.2-3 -%else -Requires: libvirt-daemon-qemu >= 0.10.2-3 -%endif +# For qemu direct and libvirt backends. +Requires: qemu-kvm-core +Requires: libvirt-daemon-driver-qemu +Requires: libvirt-daemon-driver-secret Recommends: libvirt-daemon-config-network Requires: selinux-policy >= 3.11.1-63
As pointed out in the discussion of v1, can you please add libvirt-daemon-driver-storage-core as suggest? Otherwise LGTM -- I'd wait for Dan to take a look at it too, to be double sure we are not missing anything. -- Pino Toscano
On Fri, Jan 10, 2020 at 05:51:39PM +0100, Pino Toscano wrote:
On Friday, 10 January 2020 15:59:35 CET Richard W.M. Jones wrote:
libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter.
There are no Fedora TCG-only arches, so drop the conditional section. --- libguestfs.spec | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/libguestfs.spec b/libguestfs.spec index 0d32ef0..872d430 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -211,12 +211,10 @@ Requires: fuse # For core disk-create API. Requires: /usr/bin/qemu-img
-# For libvirt backend. -%ifarch %{ix86} x86_64 %{arm} aarch64 -Requires: libvirt-daemon-kvm >= 0.10.2-3 -%else -Requires: libvirt-daemon-qemu >= 0.10.2-3 -%endif +# For qemu direct and libvirt backends. +Requires: qemu-kvm-core +Requires: libvirt-daemon-driver-qemu +Requires: libvirt-daemon-driver-secret Recommends: libvirt-daemon-config-network Requires: selinux-policy >= 3.11.1-63
As pointed out in the discussion of v1, can you please add libvirt-daemon-driver-storage-core as suggest?
Otherwise LGTM -- I'd wait for Dan to take a look at it too, to be double sure we are not missing anything.
With that suggested storage-core addition Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Fri, 10 Jan 2020 17:51:39 +0100 Pino Toscano <ptoscano@redhat.com> wrote:
On Friday, 10 January 2020 15:59:35 CET Richard W.M. Jones wrote:
libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter.
There are no Fedora TCG-only arches, so drop the conditional section. --- libguestfs.spec | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/libguestfs.spec b/libguestfs.spec index 0d32ef0..872d430 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -211,12 +211,10 @@ Requires: fuse # For core disk-create API. Requires: /usr/bin/qemu-img
-# For libvirt backend. -%ifarch %{ix86} x86_64 %{arm} aarch64 -Requires: libvirt-daemon-kvm >= 0.10.2-3 -%else -Requires: libvirt-daemon-qemu >= 0.10.2-3 -%endif +# For qemu direct and libvirt backends. +Requires: qemu-kvm-core +Requires: libvirt-daemon-driver-qemu +Requires: libvirt-daemon-driver-secret Recommends: libvirt-daemon-config-network Requires: selinux-policy >= 3.11.1-63
As pointed out in the discussion of v1, can you please add libvirt-daemon-driver-storage-core as suggest?
Otherwise LGTM -- I'd wait for Dan to take a look at it too, to be double sure we are not missing anything.
I see nothing obviously wrong and if Rich (or you) could provide a F-31 scratch build, I will give it a real-world test. Dan
participants (4)
-
Dan Horák -
Daniel P. Berrangé -
Pino Toscano -
Richard W.M. Jones