[PATCH] New API: ufs-growfs to grow UFS filesystems.
This simple patch adds support for the BSD "growfs" command, so you can grow BSD filesystems [in theory -- see below]. It also adds a new optional group called "ufsutils" which indicates if the libguestfs API supports the guestfs_ufs_growfs call, since it's not available on Fedora. (http://libguestfs.org/guestfs.3.html#availability) I tested this on Debian, and although we appear to be invoking the growfs.ufs command correctly, the growfs command contains a bug. It appears that Debian doesn't implement the BSD DIOCGSECTORSIZE ioctl, which means that growfs on Debian always dies with this error message: bogus sectorsize: 0 This appears to be a Debian bug. Someone else can do a bit more investigation on that one and file a bug if necessary. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
Seems everything is fine. In nearest time I will test it on several freebsd guests. On 13 June 2011 15:29, Richard W.M. Jones <rjones@redhat.com> wrote:
This simple patch adds support for the BSD "growfs" command, so you can grow BSD filesystems [in theory -- see below].
It also adds a new optional group called "ufsutils" which indicates if the libguestfs API supports the guestfs_ufs_growfs call, since it's not available on Fedora. (http://libguestfs.org/guestfs.3.html#availability)
I tested this on Debian, and although we appear to be invoking the growfs.ufs command correctly, the growfs command contains a bug. It appears that Debian doesn't implement the BSD DIOCGSECTORSIZE ioctl, which means that growfs on Debian always dies with this error message:
bogus sectorsize: 0
This appears to be a Debian bug. Someone else can do a bit more investigation on that one and file a bug if necessary.
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
-- Nikita A Menkovich http://libc6.org/ JID: menkovich@gmail.com Tel: +7 (921) 423-96-48
On Mon, Jun 13, 2011 at 03:39:17PM +0400, Nikita A Menkovich wrote:
Seems everything is fine. In nearest time I will test it on several freebsd guests.
Yes, please test the patch. I suspect you will just run into the growfs bug that I mentioned though, although that looks like it's easy to fix. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
participants (2)
-
Nikita A Menkovich -
Richard W.M. Jones