On Tue, Feb 17, 2015 at 07:09:37AM +0000, Chen, Hanxiao wrote:

Hi Rich,

Currently we had btrfs-set-seeding for btrfstune.

But btrfstune had more options: usage: btrfstune [options] device -S value positive value will enable seeding, zero to disable, negative is not allowed -r enable extended inode refs -x enable skinny metadata extent refs -f force to clear flags, make sure that you are aware of the dangers

If I want to add more options for btrfstune: 1) expand current btrfs-set-seeding command 2) add new btrfs-tune-XXX which cover current btrfs-set-seeding 3) add new btrfs-tune-XXX as supplyments for btrfs-set-seeding

Which style do you prefer?

I think it will be less surprising for users if the libguestfs API more closely follows the upstream btrfs commands (ie. options 2 and/or 3). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html