[PATCH 0/3] Three code cleanups
As suggested by Jim in this earlier message: https://www.redhat.com/archives/libguestfs/2009-September/msg00152.html Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
Identical changes are made to the five directories: cat/ df/ edit/ inspector/ rescue/ -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 75 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
Richard W.M. Jones wrote:
Identical changes are made to the five directories: Subject: [PATCH 1/3] Replace @...@ with $(...) in these common Makefile.am files. cat/Makefile.am | 8 ++++---- df/Makefile.am | 8 ++++---- edit/Makefile.am | 8 ++++---- inspector/Makefile.am | 8 ++++---- rescue/Makefile.am | 8 ++++---- 5 files changed, 20 insertions(+), 20 deletions(-)
ACK. Looks nice and mechanical.
-- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
Richard W.M. Jones wrote: ...
Subject: [PATCH 2/3] Create manpage atomically.
Don't fail with a partial file if disk full, etc. --- cat/Makefile.am | 2 +- df/Makefile.am | 2 +- edit/Makefile.am | 2 +- inspector/Makefile.am | 2 +- rescue/Makefile.am | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
ACK. Thanks.
-- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
Richard W.M. Jones wrote:
Subject: [PATCH 3/3] Check return value from readlink.
--- cat/run-cat-locally | 2 +- df/run-df-locally | 2 +- edit/run-edit-locally | 2 +- inspector/run-inspector-locally | 2 +- rescue/run-rescue-locally | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
ACK. Glad you thought to look for other unchecked uses.
participants (2)
-
Jim Meyering -
Richard W.M. Jones