two patches one for disabling vmware tools and one for disabling parallel port
Since we agree on the first part I have divided it into two patches. Amos.
On Thu, Jun 03, 2010 at 04:21:17PM -0400, Amos Benari wrote:
Since we agree on the first part I have divided it into two patches.
I think we can apply the vmware tools one, but the parport one needs some change. Perhaps it should change the name of the function, or perhaps we can integrate all the registry changing code into a single function somehow (to avoid repeatedly downloading and uploading the file). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
On 06/04/2010 05:00 AM, Richard W.M. Jones wrote:
On Thu, Jun 03, 2010 at 04:21:17PM -0400, Amos Benari wrote:
Since we agree on the first part I have divided it into two patches.
I think we can apply the vmware tools one, but the parport one needs some change. Perhaps it should change the name of the function, or perhaps we can integrate all the registry changing code into a single function somehow (to avoid repeatedly downloading and uploading the file).
Rich.
The autorun should also be cleared for "vmware-tray" and some other "vmwareuser.exe" programs in "HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\Run " And we also need to check the install path for it, since on x86_64 windows, vmware tools are installed in "Program files(x86)" dir while not "Program files" dir (Maybe, I can not remember clearly). So it is better just match any "vmware*.exe" files in the "\CurrentVersion\Run" Key and delete them. Regards, Pengzhen
-----Original Message----- From: Richard W.M. Jones [mailto:rjones@redhat.com] Sent: Friday, June 04, 2010 12:01 AM To: Amos Benari Cc: libguestfs@redhat.com Subject: Re: [Libguestfs] two patches one for disabling vmware tools and one for disabling parallel port
On Thu, Jun 03, 2010 at 04:21:17PM -0400, Amos Benari wrote:
Since we agree on the first part I have divided it into two patches.
I think we can apply the vmware tools one, but the parport one needs some change. Perhaps it should change the name of the function, or perhaps we can integrate all the registry changing code into a single function somehow (to avoid repeatedly downloading and uploading the file).
OK, let's add the first one. I will later refactor the file for the second patch. I thought it's kind of over doing to refactor the file for a one liner, but I'll be happy to do so. Amos
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
participants (3)
-
Amos Benari -
Pengzhen Cao -
Richard W.M. Jones