[PATCH] file: Fix file command on /dev/VG/LV paths (RHBZ#582484).
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
On 08/06/10 16:07, Richard W.M. Jones wrote:
From ba39ced8804765705f4c61a92db0fddb8d672c7d Mon Sep 17 00:00:00 2001 From: Richard Jones<rjones@redhat.com> Date: Tue, 8 Jun 2010 16:04:01 +0100 Subject: [PATCH] file: Fix file command on /dev/VG/LV paths (RHBZ#582484).
Previous commit 4df593496e116dfb635731c058b7627e81fc179c broke the "file" command on logical volume paths, since these are symbolic links. We*should* follow these (only).
This inadvertantly broke virt-inspector too, which indicates that we need more regression testing in this area. Since carrying whole Fedora images around could make the distribution even larger than now, I'm not sure at the moment how to do this.
Thanks to Matt Booth for diagnosing this bug. --- daemon/file.c | 7 ++++++- src/generator.ml | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-)
ACK. However, as discussed on IRC this call is now a bit of a mess. Could we please deprecate it in favour of a new one? On a related note, perhaps we should update virt-inspector to use vfs_type instead of file. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
On Tue, Jun 08, 2010 at 05:38:34PM +0100, Matthew Booth wrote:
However, as discussed on IRC this call is now a bit of a mess. Could we please deprecate it in favour of a new one?
On a related note, perhaps we should update virt-inspector to use vfs_type instead of file.
Yes to both, although not right now. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
participants (2)
-
Matthew Booth -
Richard W.M. Jones