[PATCH] Add a prefix to output when tracing (RHBZ#673479).
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
On 28/01/11 11:15, Richard W.M. Jones wrote:
From 21d41177fd8bc429f514227903329bc18bc33a64 Mon Sep 17 00:00:00 2001 From: Richard W.M. Jones<rjones@redhat.com> Date: Fri, 28 Jan 2011 11:14:42 +0000 Subject: [PATCH] Add a prefix to output when tracing (RHBZ#673479).
--- generator/generator_c.ml | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
This is fine. However, it doesn't completely solve the issue of intermingling TRACE and DEBUG output, because DEBUG will be embedded in between the command and result parts of the TRACE output. As discussed on IRC, how about putting the result on a separate line? Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
A slight simplification of the previous patch. The output is the same. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
On 28/01/11 11:54, Richard W.M. Jones wrote:
From 1d999540bddd7aea7c2d0fef8b15223d4acc645f Mon Sep 17 00:00:00 2001 From: Richard W.M. Jones<rjones@redhat.com> Date: Fri, 28 Jan 2011 11:14:42 +0000 Subject: [PATCH] Add a prefix to output when tracing (RHBZ#673479).
Also separate the call and return lines so that everything can be easily 'grepped' from debug output. The trace output now looks like this:
$ guestfish -x -N fs exit libguestfs: trace: is_config libguestfs: trace: is_config = 1 libguestfs: trace: add_drive "test1.img" libguestfs: trace: add_drive = 0 libguestfs: trace: is_config libguestfs: trace: is_config = 1 libguestfs: trace: launch libguestfs: trace: launch = 0 libguestfs: trace: part_disk "/dev/sda" "mbr" libguestfs: trace: part_disk = 0 &c. --- generator/generator_c.ml | 44 +++++++++++++++++++++++++++----------------- 1 files changed, 27 insertions(+), 17 deletions(-)
ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
participants (2)
-
Matthew Booth -
Richard W.M. Jones