Re: [PATCH nbdkit] vddk: Detect possible VDDK crash and warn
On Fri, Aug 16, 2024 at 10:05:00AM -0400, Matthew Arnold wrote:
Matthew, does this only happen when the snapshot parameter is present?
I am not sure, without it we fail earlier with "You do not have access rights to this file".
Ah I see. I think I'm going to remove the snapshot_moref test anyway. We can add it back if someone finds evidence that it's needed to trigger the crash. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit
On Fri, Aug 16, 2024 at 03:13:43PM +0100, Richard W.M. Jones wrote:
On Fri, Aug 16, 2024 at 10:05:00AM -0400, Matthew Arnold wrote:
Matthew, does this only happen when the snapshot parameter is present?
I am not sure, without it we fail earlier with "You do not have access rights to this file".
Ah I see. I think I'm going to remove the snapshot_moref test anyway. We can add it back if someone finds evidence that it's needed to trigger the crash.
Upstream in 6f399662b6, thanks everyone. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
participants (1)
-
Richard W.M. Jones