8:07 a.m.
Should we do this yet? It would of course only be for upstream.
It also requires an associated patch to common which I will post
separately.
Rich.
8:07 a.m.
---
m4/guestfs-libraries.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/guestfs-libraries.m4 b/m4/guestfs-libraries.m4
index 7a24c0a3f..da541d8f6 100644
--- a/m4/guestfs-libraries.m4
+++ b/m4/guestfs-libraries.m4
@@ -18,7 +18,7 @@
dnl Any C libraries required by virt-v2v.
dnl Of course we need libguestfs.
-PKG_CHECK_MODULES([LIBGUESTFS], [libguestfs >= 1.40])
+PKG_CHECK_MODULES([LIBGUESTFS], [libguestfs >= 1.42])
dnl Define a C symbol for the host CPU architecture.
AC_DEFINE_UNQUOTED([host_cpu],["$host_cpu"],[Host architecture.])
--
2.25.0
8:16 a.m.
On Tuesday, 10 March 2020 14:07:41 CET Richard W.M. Jones wrote:
Should we do this yet? It would of course only be for upstream.
Not sure why it should be "upstream only".
In any case, the big issue in this case is that you cannot build
virt-v2v with libguestfs from git. So until that is done, bumping
the version requirements means that almost noone (unless they install
libguestfs) can work on virt-v2v...
--
Pino Toscano
9:19 a.m.
On Tue, Mar 10, 2020 at 02:16:28PM +0100, Pino Toscano wrote:
On Tuesday, 10 March 2020 14:07:41 CET Richard W.M. Jones wrote:
> Should we do this yet? It would of course only be for upstream.
Not sure why it should be "upstream only".
I meant only that we would just put it in git, and not try to backport
it (so it wouldn't affect people using current tarballs).
In any case, the big issue in this case is that you cannot build
virt-v2v with libguestfs from git. So until that is done, bumping
the version requirements means that almost noone (unless they install
libguestfs) can work on virt-v2v...
I guess because virt-v2v and libguestfs are more intimately connected
than other dependencies, it's worth trying to make this work. I
thought we could do it already using ‘../libguestfs/run’, so I
uninstalled libguestfs from my laptop and tried it, but:
$ ../libguestfs/run ./autogen.sh [other stuff] && make
checking for LIBGUESTFS... no
configure: error: Package requirements (libguestfs >= 1.40) were not met:
Well how hard can it be ... I'll see if I can fix this.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
1546
days inactive
1546
days old
3 comments
2 participants
participants (2)
-
Pino Toscano -
Richard W.M. Jones