[PATCH] New commands to list devices by UUID and label (updated patch)
A new version of this patch, previously posted here: https://www.redhat.com/archives/libguestfs/2009-August/thread.html#00031 I've made some of the changes that Jim suggested, but I didn't fix the error handling of readdir because that loop always reads from a tmpfs. It didn't seem like there would realistically be any read errors(?) These commands are compromised in their usefulness by a long-standing LVM bug (https://bugzilla.redhat.com/show_bug.cgi?id=465691), which means they won't list anything for LVM devices on Fedora. They should work on non-Fedora-derived platforms however. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
On 06/08/09 15:09, Richard W.M. Jones wrote:
A new version of this patch, previously posted here:
https://www.redhat.com/archives/libguestfs/2009-August/thread.html#00031
I've made some of the changes that Jim suggested, but I didn't fix the error handling of readdir because that loop always reads from a tmpfs. It didn't seem like there would realistically be any read errors(?)
It always reads from a tmpfs today. But in a few months somebody's going to change it so that it doesn't for some unrelated really good reason, and then it'll be a bug :) Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
participants (2)
-
Matthew Booth -
Richard W.M. Jones