Testing github pull requests
I've sent a github pull request containing this patch here: https://github.com/libguestfs/libguestfs/pull/1 I'm interested to know if this interface could be useful to the project. We should be wary, though, of tying useful development history in the form of review discussion into github's proprietary system. Your thoughts are appreciated. Incidentally, I'm also looking for ACKs on this patch :) Matt
Remove generated file from source control, and don't barf when it doesn't exist while bootstrapping. --- generator/.depend | 158 ------------------------------------------------- generator/Makefile.am | 2 +- 2 files changed, 1 insertions(+), 159 deletions(-) delete mode 100644 generator/.depend diff --git a/generator/.depend b/generator/.depend deleted file mode 100644 index acbce64..0000000 --- a/generator/.depend +++ /dev/null @@ -1,158 +0,0 @@ -generator_types.cmo: -generator_types.cmx: -generator_utils.cmi: generator_types.cmo -generator_utils.cmo: generator_types.cmo generator_utils.cmi -generator_utils.cmx: generator_types.cmx generator_utils.cmi -generator_actions.cmi: generator_types.cmo -generator_actions.cmo: generator_utils.cmi generator_types.cmo \ - generator_actions.cmi -generator_actions.cmx: generator_utils.cmx generator_types.cmx \ - generator_actions.cmi -generator_structs.cmi: generator_types.cmo -generator_structs.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi -generator_structs.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmi -generator_api_versions.cmi: -generator_api_versions.cmo: generator_utils.cmi generator_api_versions.cmi -generator_api_versions.cmx: generator_utils.cmx generator_api_versions.cmi -generator_optgroups.cmo: generator_types.cmo generator_actions.cmi -generator_optgroups.cmx: generator_types.cmx generator_actions.cmx -generator_prepopts.cmi: -generator_prepopts.cmo: generator_prepopts.cmi -generator_prepopts.cmx: generator_prepopts.cmi -generator_events.cmo: generator_utils.cmi -generator_events.cmx: generator_utils.cmx -generator_pr.cmi: -generator_pr.cmo: generator_utils.cmi generator_pr.cmi -generator_pr.cmx: generator_utils.cmx generator_pr.cmi -generator_docstrings.cmo: generator_utils.cmi generator_types.cmo \ - generator_pr.cmi -generator_docstrings.cmx: generator_utils.cmx generator_types.cmx \ - generator_pr.cmx -generator_checks.cmo: generator_utils.cmi generator_types.cmo \ - generator_actions.cmi -generator_checks.cmx: generator_utils.cmx generator_types.cmx \ - generator_actions.cmx -generator_c.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_api_versions.cmi \ - generator_actions.cmi -generator_c.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_api_versions.cmx \ - generator_actions.cmx -generator_xdr.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_xdr.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_daemon.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_daemon.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_tests_c_api.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_tests_c_api.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_fish.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_prepopts.cmi generator_pr.cmi \ - generator_optgroups.cmo generator_events.cmo generator_docstrings.cmo \ - generator_c.cmo generator_actions.cmi -generator_fish.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_prepopts.cmx generator_pr.cmx \ - generator_optgroups.cmx generator_events.cmx generator_docstrings.cmx \ - generator_c.cmx generator_actions.cmx -generator_ocaml.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_ocaml.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_perl.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_perl.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_python.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_python.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_ruby.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_ruby.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_java.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_java.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_haskell.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_haskell.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_csharp.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_csharp.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_php.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_php.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_erlang.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_erlang.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_bindtests.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_bindtests.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_errnostring.cmo: generator_utils.cmi generator_types.cmo \ - generator_pr.cmi generator_docstrings.cmo -generator_errnostring.cmx: generator_utils.cmx generator_types.cmx \ - generator_pr.cmx generator_docstrings.cmx -generator_main.cmo: generator_xdr.cmo generator_tests_c_api.cmo \ - generator_structs.cmi generator_ruby.cmo generator_python.cmo \ - generator_pr.cmi generator_php.cmo generator_perl.cmo generator_ocaml.cmo \ - generator_java.cmo generator_haskell.cmo generator_fish.cmo \ - generator_errnostring.cmo generator_erlang.cmo generator_daemon.cmo \ - generator_csharp.cmo generator_c.cmo generator_bindtests.cmo \ - generator_api_versions.cmi -generator_main.cmx: generator_xdr.cmx generator_tests_c_api.cmx \ - generator_structs.cmx generator_ruby.cmx generator_python.cmx \ - generator_pr.cmx generator_php.cmx generator_perl.cmx generator_ocaml.cmx \ - generator_java.cmx generator_haskell.cmx generator_fish.cmx \ - generator_errnostring.cmx generator_erlang.cmx generator_daemon.cmx \ - generator_csharp.cmx generator_c.cmx generator_bindtests.cmx \ - generator_api_versions.cmx diff --git a/generator/Makefile.am b/generator/Makefile.am index dfa5893..b01cf35 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -79,7 +79,7 @@ depend: .depend $(OCAMLDEP) $^ | sed 's/ *$$//' > $@-t mv $@-t $@ -include .depend +-include .depend else -- 1.7.7.5
On Wed, Jan 11, 2012 at 11:35:51AM +0000, Matthew Booth wrote:
Remove generated file from source control, and don't barf when it doesn't exist while bootstrapping. --- generator/.depend | 158 ------------------------------------------------- generator/Makefile.am | 2 +- 2 files changed, 1 insertions(+), 159 deletions(-) delete mode 100644 generator/.depend
diff --git a/generator/.depend b/generator/.depend deleted file mode 100644 index acbce64..0000000 --- a/generator/.depend +++ /dev/null @@ -1,158 +0,0 @@ -generator_types.cmo: -generator_types.cmx: -generator_utils.cmi: generator_types.cmo -generator_utils.cmo: generator_types.cmo generator_utils.cmi -generator_utils.cmx: generator_types.cmx generator_utils.cmi -generator_actions.cmi: generator_types.cmo -generator_actions.cmo: generator_utils.cmi generator_types.cmo \ - generator_actions.cmi -generator_actions.cmx: generator_utils.cmx generator_types.cmx \ - generator_actions.cmi -generator_structs.cmi: generator_types.cmo -generator_structs.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi -generator_structs.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmi -generator_api_versions.cmi: -generator_api_versions.cmo: generator_utils.cmi generator_api_versions.cmi -generator_api_versions.cmx: generator_utils.cmx generator_api_versions.cmi -generator_optgroups.cmo: generator_types.cmo generator_actions.cmi -generator_optgroups.cmx: generator_types.cmx generator_actions.cmx -generator_prepopts.cmi: -generator_prepopts.cmo: generator_prepopts.cmi -generator_prepopts.cmx: generator_prepopts.cmi -generator_events.cmo: generator_utils.cmi -generator_events.cmx: generator_utils.cmx -generator_pr.cmi: -generator_pr.cmo: generator_utils.cmi generator_pr.cmi -generator_pr.cmx: generator_utils.cmx generator_pr.cmi -generator_docstrings.cmo: generator_utils.cmi generator_types.cmo \ - generator_pr.cmi -generator_docstrings.cmx: generator_utils.cmx generator_types.cmx \ - generator_pr.cmx -generator_checks.cmo: generator_utils.cmi generator_types.cmo \ - generator_actions.cmi -generator_checks.cmx: generator_utils.cmx generator_types.cmx \ - generator_actions.cmx -generator_c.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_api_versions.cmi \ - generator_actions.cmi -generator_c.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_api_versions.cmx \ - generator_actions.cmx -generator_xdr.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_xdr.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_daemon.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_daemon.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_tests_c_api.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_tests_c_api.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_fish.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_prepopts.cmi generator_pr.cmi \ - generator_optgroups.cmo generator_events.cmo generator_docstrings.cmo \ - generator_c.cmo generator_actions.cmi -generator_fish.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_prepopts.cmx generator_pr.cmx \ - generator_optgroups.cmx generator_events.cmx generator_docstrings.cmx \ - generator_c.cmx generator_actions.cmx -generator_ocaml.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_ocaml.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_perl.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_perl.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_python.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_python.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_ruby.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_ruby.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_java.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_java.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_haskell.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_haskell.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_csharp.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_csharp.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_php.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_php.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_erlang.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_erlang.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_bindtests.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_bindtests.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_errnostring.cmo: generator_utils.cmi generator_types.cmo \ - generator_pr.cmi generator_docstrings.cmo -generator_errnostring.cmx: generator_utils.cmx generator_types.cmx \ - generator_pr.cmx generator_docstrings.cmx -generator_main.cmo: generator_xdr.cmo generator_tests_c_api.cmo \ - generator_structs.cmi generator_ruby.cmo generator_python.cmo \ - generator_pr.cmi generator_php.cmo generator_perl.cmo generator_ocaml.cmo \ - generator_java.cmo generator_haskell.cmo generator_fish.cmo \ - generator_errnostring.cmo generator_erlang.cmo generator_daemon.cmo \ - generator_csharp.cmo generator_c.cmo generator_bindtests.cmo \ - generator_api_versions.cmi -generator_main.cmx: generator_xdr.cmx generator_tests_c_api.cmx \ - generator_structs.cmx generator_ruby.cmx generator_python.cmx \ - generator_pr.cmx generator_php.cmx generator_perl.cmx generator_ocaml.cmx \ - generator_java.cmx generator_haskell.cmx generator_fish.cmx \ - generator_errnostring.cmx generator_erlang.cmx generator_daemon.cmx \ - generator_csharp.cmx generator_c.cmx generator_bindtests.cmx \ - generator_api_versions.cmx diff --git a/generator/Makefile.am b/generator/Makefile.am index dfa5893..b01cf35 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -79,7 +79,7 @@ depend: .depend $(OCAMLDEP) $^ | sed 's/ *$$//' > $@-t mv $@-t $@
-include .depend +-include .depend
else
ACK. Should we do this in other places too, eg. ocaml/.depend Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
I've updated this patch as suggested to remove all .depend files. I've tested that this doesn't affect a build of a fresh git clone. Pull request here: https://github.com/libguestfs/libguestfs/pull/2
Remove generated .depend files from source control, and don't barf when they don't exist while bootstrapping. --- .gitignore | 4 + generator/.depend | 158 ------------------------------------------------- generator/Makefile.am | 2 +- ocaml/.depend | 5 -- ocaml/Makefile.am | 2 +- resize/.depend | 9 --- resize/Makefile.am | 2 +- sparsify/.depend | 7 -- sparsify/Makefile.am | 2 +- 9 files changed, 8 insertions(+), 183 deletions(-) delete mode 100644 generator/.depend delete mode 100644 ocaml/.depend delete mode 100644 resize/.depend delete mode 100644 sparsify/.depend diff --git a/.gitignore b/.gitignore index b8be4da..0611975 100644 --- a/.gitignore +++ b/.gitignore @@ -108,6 +108,7 @@ fish/virt-tar-out.1 fuse/guestmount fuse/guestmount.1 fuse/stamp-guestmount.pod +generator/.depend generator/files-generated.txt generator/generator generator/.pod2text.data* @@ -205,6 +206,7 @@ missing *.o ocaml/bindtests ocaml/bindtests.ml +ocaml/.depend ocaml/dllmlguestfs.so ocaml/examples/create_disk ocaml/examples/guestfs-ocaml.3 @@ -289,6 +291,7 @@ python/__pycache__ rescue/stamp-virt-rescue.pod rescue/virt-rescue rescue/virt-rescue.1 +resize/.depend resize/stamp-virt-resize.pod resize/utils_tests resize/virt-resize @@ -304,6 +307,7 @@ ruby/ext/guestfs/_guestfs.so ruby/ext/guestfs/mkmf.log ruby/Rakefile run +sparsify/.depend sparsify/stamp-virt-sparsify.pod sparsify/virt-sparsify sparsify/virt-sparsify.1 diff --git a/generator/.depend b/generator/.depend deleted file mode 100644 index acbce64..0000000 --- a/generator/.depend +++ /dev/null @@ -1,158 +0,0 @@ -generator_types.cmo: -generator_types.cmx: -generator_utils.cmi: generator_types.cmo -generator_utils.cmo: generator_types.cmo generator_utils.cmi -generator_utils.cmx: generator_types.cmx generator_utils.cmi -generator_actions.cmi: generator_types.cmo -generator_actions.cmo: generator_utils.cmi generator_types.cmo \ - generator_actions.cmi -generator_actions.cmx: generator_utils.cmx generator_types.cmx \ - generator_actions.cmi -generator_structs.cmi: generator_types.cmo -generator_structs.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi -generator_structs.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmi -generator_api_versions.cmi: -generator_api_versions.cmo: generator_utils.cmi generator_api_versions.cmi -generator_api_versions.cmx: generator_utils.cmx generator_api_versions.cmi -generator_optgroups.cmo: generator_types.cmo generator_actions.cmi -generator_optgroups.cmx: generator_types.cmx generator_actions.cmx -generator_prepopts.cmi: -generator_prepopts.cmo: generator_prepopts.cmi -generator_prepopts.cmx: generator_prepopts.cmi -generator_events.cmo: generator_utils.cmi -generator_events.cmx: generator_utils.cmx -generator_pr.cmi: -generator_pr.cmo: generator_utils.cmi generator_pr.cmi -generator_pr.cmx: generator_utils.cmx generator_pr.cmi -generator_docstrings.cmo: generator_utils.cmi generator_types.cmo \ - generator_pr.cmi -generator_docstrings.cmx: generator_utils.cmx generator_types.cmx \ - generator_pr.cmx -generator_checks.cmo: generator_utils.cmi generator_types.cmo \ - generator_actions.cmi -generator_checks.cmx: generator_utils.cmx generator_types.cmx \ - generator_actions.cmx -generator_c.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_api_versions.cmi \ - generator_actions.cmi -generator_c.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_api_versions.cmx \ - generator_actions.cmx -generator_xdr.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_xdr.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_daemon.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_daemon.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_tests_c_api.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_tests_c_api.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_fish.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_prepopts.cmi generator_pr.cmi \ - generator_optgroups.cmo generator_events.cmo generator_docstrings.cmo \ - generator_c.cmo generator_actions.cmi -generator_fish.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_prepopts.cmx generator_pr.cmx \ - generator_optgroups.cmx generator_events.cmx generator_docstrings.cmx \ - generator_c.cmx generator_actions.cmx -generator_ocaml.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_ocaml.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_perl.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_perl.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_python.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_python.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_ruby.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_ruby.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_java.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_java.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_haskell.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_haskell.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_csharp.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_csharp.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_php.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_php.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_erlang.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_erlang.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_bindtests.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_bindtests.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_errnostring.cmo: generator_utils.cmi generator_types.cmo \ - generator_pr.cmi generator_docstrings.cmo -generator_errnostring.cmx: generator_utils.cmx generator_types.cmx \ - generator_pr.cmx generator_docstrings.cmx -generator_main.cmo: generator_xdr.cmo generator_tests_c_api.cmo \ - generator_structs.cmi generator_ruby.cmo generator_python.cmo \ - generator_pr.cmi generator_php.cmo generator_perl.cmo generator_ocaml.cmo \ - generator_java.cmo generator_haskell.cmo generator_fish.cmo \ - generator_errnostring.cmo generator_erlang.cmo generator_daemon.cmo \ - generator_csharp.cmo generator_c.cmo generator_bindtests.cmo \ - generator_api_versions.cmi -generator_main.cmx: generator_xdr.cmx generator_tests_c_api.cmx \ - generator_structs.cmx generator_ruby.cmx generator_python.cmx \ - generator_pr.cmx generator_php.cmx generator_perl.cmx generator_ocaml.cmx \ - generator_java.cmx generator_haskell.cmx generator_fish.cmx \ - generator_errnostring.cmx generator_erlang.cmx generator_daemon.cmx \ - generator_csharp.cmx generator_c.cmx generator_bindtests.cmx \ - generator_api_versions.cmx diff --git a/generator/Makefile.am b/generator/Makefile.am index dfa5893..b01cf35 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -79,7 +79,7 @@ depend: .depend $(OCAMLDEP) $^ | sed 's/ *$$//' > $@-t mv $@-t $@ -include .depend +-include .depend else diff --git a/ocaml/.depend b/ocaml/.depend deleted file mode 100644 index cc3febf..0000000 --- a/ocaml/.depend +++ /dev/null @@ -1,5 +0,0 @@ -bindtests.cmo: guestfs.cmi -bindtests.cmx: guestfs.cmx -guestfs.cmi: -guestfs.cmo: guestfs.cmi -guestfs.cmx: guestfs.cmi diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index 95185ef..83c0ed4 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -144,7 +144,7 @@ depend: .depend LANG=C sort > $@-t mv $@-t $@ -include .depend +-include .depend SUFFIXES = .cmo .cmi .cmx .ml .mli .mll .mly diff --git a/resize/.depend b/resize/.depend deleted file mode 100644 index 14d8b51..0000000 --- a/resize/.depend +++ /dev/null @@ -1,9 +0,0 @@ -progress.cmi: ../ocaml/guestfs.cmi -progress.cmo: utils.cmo ../ocaml/guestfs.cmi progress.cmi -progress.cmx: utils.cmx ../ocaml/guestfs.cmx progress.cmi -resize.cmo: utils.cmo progress.cmi ../ocaml/guestfs.cmi -resize.cmx: utils.cmx progress.cmx ../ocaml/guestfs.cmx -utils.cmo: ../ocaml/guestfs.cmi -utils.cmx: ../ocaml/guestfs.cmx -utils_tests.cmo: utils.cmo -utils_tests.cmx: utils.cmx diff --git a/resize/Makefile.am b/resize/Makefile.am index 3f33118..5227c23 100644 --- a/resize/Makefile.am +++ b/resize/Makefile.am @@ -120,7 +120,7 @@ depend: .depend sort > $@-t mv $@-t $@ -include .depend +-include .depend endif diff --git a/sparsify/.depend b/sparsify/.depend deleted file mode 100644 index a6c60a9..0000000 --- a/sparsify/.depend +++ /dev/null @@ -1,7 +0,0 @@ -progress.cmi: ../ocaml/guestfs.cmi -progress.cmo: utils.cmo ../ocaml/guestfs.cmi progress.cmi -progress.cmx: utils.cmx ../ocaml/guestfs.cmx progress.cmi -sparsify.cmo: utils.cmo progress.cmi ../ocaml/guestfs.cmi -sparsify.cmx: utils.cmx progress.cmx ../ocaml/guestfs.cmx -utils.cmo: ../ocaml/guestfs.cmi -utils.cmx: ../ocaml/guestfs.cmx diff --git a/sparsify/Makefile.am b/sparsify/Makefile.am index 9d5e076..4f735c8 100644 --- a/sparsify/Makefile.am +++ b/sparsify/Makefile.am @@ -113,7 +113,7 @@ depend: .depend sort > $@-t mv $@-t $@ -include .depend +-include .depend endif -- 1.7.7.5
On Wed, Jan 11, 2012 at 04:22:15PM +0000, Matthew Booth wrote:
Remove generated .depend files from source control, and don't barf when they don't exist while bootstrapping.
ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
On Wed, Jan 11, 2012 at 11:35:50AM +0000, Matthew Booth wrote:
I've sent a github pull request containing this patch here:
https://github.com/libguestfs/libguestfs/pull/1
I'm interested to know if this interface could be useful to the project. We should be wary, though, of tying useful development history in the form of review discussion into github's proprietary system. Your thoughts are appreciated.
I don't think we should be using a closed source, web-based tool to do reviews, and we should stick with the mailing list for now. OTOH pull requests themselves are a useful way for committers to test patches, and also to commit patches that come from people who don't have commit rights. Thus adding a git URL (be it github or another mirror you want to use) to patches that are also posted to the mailing list can be useful. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
On 01/11/2012 07:53 PM, Richard W.M. Jones wrote:
On Wed, Jan 11, 2012 at 11:35:50AM +0000, Matthew Booth wrote:
I've sent a github pull request containing this patch here:
https://github.com/libguestfs/libguestfs/pull/1
I'm interested to know if this interface could be useful to the project. We should be wary, though, of tying useful development history in the form of review discussion into github's proprietary system. Your thoughts are appreciated.
I don't think we should be using a closed source, web-based tool to do reviews, and we should stick with the mailing list for now.
OTOH pull requests themselves are a useful way for committers to test patches, and also to commit patches that come from people who don't have commit rights. Thus adding a git URL (be it github or another mirror you want to use) to patches that are also posted to the mailing
Yeah, agree. Thanks -Wanlong Gao
list can be useful.
Rich.
participants (3)
-
Matthew Booth -
Richard W.M. Jones -
Wanlong Gao