[PATCH] add default (unversioned) directory for guest agent on EL
There was no source directory for EL8 guest agent (only EL6 and EL7). RHBZ#1791802 Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 5ec7664b..6ddc488a 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -192,7 +192,7 @@ and install_linux_tools g inspect = (match inspect.i_major_version with | 6 -> Some "el6" | 7 -> Some "el7" - | _ -> None) + | _ -> Some "el") | "sles" | "suse-based" | "opensuse" -> Some "lp151" | _ -> None in -- 2.24.1
On Thursday, 16 January 2020 15:02:52 CET Tomáš Golembiovský wrote:
There was no source directory for EL8 guest agent (only EL6 and EL7).
RHBZ#1791802
Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 5ec7664b..6ddc488a 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -192,7 +192,7 @@ and install_linux_tools g inspect = (match inspect.i_major_version with | 6 -> Some "el6" | 7 -> Some "el7" - | _ -> None) + | _ -> Some "el")
I do not agree with this solution: the major series of EL systems are very different in the base OS/toolchain, so I do not think installing a (say) RHEL 8 package on a greater version is a good idea. IMHO changing it to "elX" where X is the major version of EL is a better solution (and simplifies that code a bit). -- Pino Toscano
On Thu, Jan 16, 2020 at 03:02:52PM +0100, Tomáš Golembiovský wrote:
There was no source directory for EL8 guest agent (only EL6 and EL7).
RHBZ#1791802
Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 5ec7664b..6ddc488a 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -192,7 +192,7 @@ and install_linux_tools g inspect = (match inspect.i_major_version with | 6 -> Some "el6" | 7 -> Some "el7" - | _ -> None) + | _ -> Some "el") | "sles" | "suse-based" | "opensuse" -> Some "lp151" | _ -> None in
As far as this patch for v2v goes it's fine, but as Pino says it does seem as if the ISO itself is storing up trouble for the future :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
participants (3)
-
Pino Toscano -
Richard W.M. Jones -
Tomáš Golembiovský