[PATCH v2v] config: 'os' and 'distro' fields should be matched separately.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html
On 06/05/10 17:54, Richard W.M. Jones wrote:
From ca375bb29295523238e297820d4f641db01d9742 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones@redhat.com> Date: Thu, 6 May 2010 17:51:58 +0100 Subject: [PATCH 1/2] config: 'os' and 'distro' fields should be matched separately.
This is particularly important for Windows guests, because these only have os='windows' and distro is not set. --- lib/Sys/VirtV2V/Config.pm | 30 ++++++++++++++++++------------ v2v/virt-v2v.conf | 34 +++++++++++++++++----------------- 2 files changed, 35 insertions(+), 29 deletions(-)
Could you please also update v2v/virt-v2v.conf.pod? Otherwise, ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
On Fri, May 07, 2010 at 11:05:52AM +0100, Matthew Booth wrote:
On 06/05/10 17:54, Richard W.M. Jones wrote:
From ca375bb29295523238e297820d4f641db01d9742 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones@redhat.com> Date: Thu, 6 May 2010 17:51:58 +0100 Subject: [PATCH 1/2] config: 'os' and 'distro' fields should be matched separately.
This is particularly important for Windows guests, because these only have os='windows' and distro is not set. --- lib/Sys/VirtV2V/Config.pm | 30 ++++++++++++++++++------------ v2v/virt-v2v.conf | 34 +++++++++++++++++----------------- 2 files changed, 35 insertions(+), 29 deletions(-)
Could you please also update v2v/virt-v2v.conf.pod?
Will do .. I forgot about that file. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
On Fri, May 07, 2010 at 11:05:52AM +0100, Matthew Booth wrote:
On 06/05/10 17:54, Richard W.M. Jones wrote:
From ca375bb29295523238e297820d4f641db01d9742 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones@redhat.com> Date: Thu, 6 May 2010 17:51:58 +0100 Subject: [PATCH 1/2] config: 'os' and 'distro' fields should be matched separately.
This is particularly important for Windows guests, because these only have os='windows' and distro is not set. --- lib/Sys/VirtV2V/Config.pm | 30 ++++++++++++++++++------------ v2v/virt-v2v.conf | 34 +++++++++++++++++----------------- 2 files changed, 35 insertions(+), 29 deletions(-)
Could you please also update v2v/virt-v2v.conf.pod?
How about this [attached]? You say in the documentation that matching happens in this order: · os, distro, major, minor, arch · os, distro, major, minor · os, distro, major, arch · os, distro, major · os, distro · os but is that really true? Also I don't think it's a good idea to include the whole default configuration file in the man page. I think you should just tell them where to look for it. If you agree I will prepare an updated patch. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
On 07/05/10 11:28, Richard W.M. Jones wrote:
On Fri, May 07, 2010 at 11:05:52AM +0100, Matthew Booth wrote:
On 06/05/10 17:54, Richard W.M. Jones wrote:
From ca375bb29295523238e297820d4f641db01d9742 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones@redhat.com> Date: Thu, 6 May 2010 17:51:58 +0100 Subject: [PATCH 1/2] config: 'os' and 'distro' fields should be matched separately.
This is particularly important for Windows guests, because these only have os='windows' and distro is not set. --- lib/Sys/VirtV2V/Config.pm | 30 ++++++++++++++++++------------ v2v/virt-v2v.conf | 34 +++++++++++++++++----------------- 2 files changed, 35 insertions(+), 29 deletions(-)
Could you please also update v2v/virt-v2v.conf.pod?
How about this [attached]?
Looks fine.
You say in the documentation that matching happens in this order:
· os, distro, major, minor, arch
· os, distro, major, minor
· os, distro, major, arch
· os, distro, major
· os, distro
· os
but is that really true?
I belived so when I wrote it :) If it isn't it's a bug.
Also I don't think it's a good idea to include the whole default configuration file in the man page. I think you should just tell them where to look for it. If you agree I will prepare an updated patch.
You're probably right. A pointer to the default is probably sufficient. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
On Fri, May 07, 2010 at 01:24:55PM +0100, Matthew Booth wrote:
On 07/05/10 11:28, Richard W.M. Jones wrote:
You say in the documentation that matching happens in this order:
· os, distro, major, minor, arch
· os, distro, major, minor
· os, distro, major, arch
· os, distro, major
· os, distro
· os
but is that really true?
I belived so when I wrote it :) If it isn't it's a bug.
I left this bit in, and removed the inline virt-v2v.conf (referring instead to the external file which we bundle in %docdir). Please ACK the attached complete patch which I propose to push. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
On 07/05/10 13:41, Richard W.M. Jones wrote:
From ffdaeef59f81c46ef84a827ba3f4ec39dbf7e85c Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones@redhat.com> Date: Thu, 6 May 2010 17:51:58 +0100 Subject: [PATCH 1/2] config: 'os' and 'distro' fields should be matched separately.
This is particularly important for Windows guests, because these only have os='windows' and distro is not set.
This commit also updates the virt-v2v.conf documentation. --- lib/Sys/VirtV2V/Config.pm | 30 +++++--- v2v/virt-v2v.conf | 34 +++++----- v2v/virt-v2v.conf.pod | 163 +++++++-------------------------------------- 3 files changed, 60 insertions(+), 167 deletions(-)
ACK. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
participants (2)
-
Matthew Booth -
Richard W.M. Jones