[PATCH 1/2] Create an MD variant of the dummy Fedora image
This change involves rewriting make-fedora-img.sh in perl. This allows the flexibility to write mdadm.conf containing whichever uuids where randomly generated when the md devices were created. --- .gitignore | 2 + images/Makefile.am | 18 +++- images/guest-aux/make-fedora-img.pl | 194 +++++++++++++++++++++++++++++++++++ images/guest-aux/make-fedora-img.sh | 110 -------------------- 4 files changed, 210 insertions(+), 114 deletions(-) create mode 100755 images/guest-aux/make-fedora-img.pl delete mode 100755 images/guest-aux/make-fedora-img.sh
--- Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
General comment: Can you use git send-email to send the patches? I think I had problems applying those patches before, but now I'm finding it problematic to apply patches that are attachments.
+# Make a (dummy) Fedora image using md devices +fedora-md1.img fedora-md2.img: guest-aux/make-fedora-img.pl \
I believe this will run the Perl script twice on updates. You need to use a stamp file, eg: fedora-md1.img fedora-md2.img: stamp-fedora-md stamp-fedora-md: guest-aux/make-fedora-img.pl [etc] [rules] The tests pass for me, so ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
On 22/11/11 16:01, Richard W.M. Jones wrote:
General comment:
Can you use git send-email to send the patches? I think I had problems applying those patches before, but now I'm finding it problematic to apply patches that are attachments.
I do use git send-email, and if you remember I only changed the defaults because you were having problems with them ;) I currently have this in .git/config in my local libguestfs repo: [format] attach I'll remove it again...
+# Make a (dummy) Fedora image using md devices +fedora-md1.img fedora-md2.img: guest-aux/make-fedora-img.pl \
I believe this will run the Perl script twice on updates. You need to use a stamp file, eg:
fedora-md1.img fedora-md2.img: stamp-fedora-md
stamp-fedora-md: guest-aux/make-fedora-img.pl [etc] [rules]
I don't think it will. Makefile will process the 2 images files in order. The creation of fedora-md1.img will also create fedora-md2.img. When processing fedora-md2.img, the timestamp check will prevent it being run again. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
On 11/22/2011 11:29 PM, Matthew Booth wrote:
This change involves rewriting make-fedora-img.sh in perl. This allows the flexibility to write mdadm.conf containing whichever uuids where randomly generated when the md devices were created.
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
--- .gitignore | 2 + images/Makefile.am | 18 +++- images/guest-aux/make-fedora-img.pl | 194 +++++++++++++++++++++++++++++++++++ images/guest-aux/make-fedora-img.sh | 110 -------------------- 4 files changed, 210 insertions(+), 114 deletions(-) create mode 100755 images/guest-aux/make-fedora-img.pl delete mode 100755 images/guest-aux/make-fedora-img.sh
Applied this patch by *patch -p1 < xxx* will lost the *file mode*. So, I'd like to use *git send-email* without patch attached. Or, did I miss something? Thanks -Wanlong Gao
_______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
participants (3)
-
Matthew Booth -
Richard W.M. Jones -
Wanlong Gao