Patch that implements support to create UFS1 partitions with mkfs-opts
In attach. Usage:
mkfs-opts ufs /dev/vda1 features:1 Creates UFS1 partition mkfs-opts ufs /dev/vda1 features:2 Creates UFS2 partition. -- Nikita A Menkovich JID: menkovich@gmail.com Tel: +7 (921) 423-96-48
On Wed, Jan 26, 2011 at 06:06:54PM +0300, Nikita A Menkovich wrote:
+ if (optargs_bitmask & GUESTFS_MKFS_OPTS_FEATURES_BITMASK) { + if (STREQ (fstype, "ufs")) { + argv[i++] = "-O"; + argv[i++] = features; + } + }
Is there a reason to restrict this to ufs? ext2/3/4 also has features which can be configured through the -O option. I removed the inner 'if' statement.
+For UFS the C<blocksize> parameter by default is C<16384>, minimal is C<4096>.
This is interesting information, but by declaring it here it ties us our ABI to some particular feature of Debian 'ufsutils'. I have made this into a separate patch and changed the wording a bit so that we aren't promising anything. Please see the attached 2 x patches. If these are suitable for you, I will commit them. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
Yes, this all will be fine. On 26 January 2011 18:37, Richard W.M. Jones <rjones@redhat.com> wrote:
On Wed, Jan 26, 2011 at 06:06:54PM +0300, Nikita A Menkovich wrote:
+ if (optargs_bitmask & GUESTFS_MKFS_OPTS_FEATURES_BITMASK) { + if (STREQ (fstype, "ufs")) { + argv[i++] = "-O"; + argv[i++] = features; + } + }
Is there a reason to restrict this to ufs? ext2/3/4 also has features which can be configured through the -O option. I removed the inner 'if' statement.
+For UFS the C<blocksize> parameter by default is C<16384>, minimal is C<4096>.
This is interesting information, but by declaring it here it ties us our ABI to some particular feature of Debian 'ufsutils'. I have made this into a separate patch and changed the wording a bit so that we aren't promising anything.
Please see the attached 2 x patches. If these are suitable for you, I will commit them.
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
-- Nikita A Menkovich JID: menkovich@gmail.com Tel: +7 (921) 423-96-48
participants (2)
-
Nikita A Menkovich -
Richard W.M. Jones