[PATCH] Fix error with --uninstall option on SUSE
The `-l` option for some `zypper` subcommands is short for `--auto-agree-with-licenses` and not available on the `zypper rm` command. --- customize/customize_run.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index f92e9a199..3eacdaca0 100644 --- a/customize/customize_run.ml +++ b/customize/customize_run.ml @@ -181,7 +181,7 @@ exec >>%s 2>&1 | "urpmi" -> sprintf "urpme %s" quoted_args | "xbps" -> sprintf "xbps-remove -Sy %s" quoted_args | "yum" -> sprintf "yum -y remove %s" quoted_args - | "zypper" -> sprintf "zypper -n rm -l %s" quoted_args + | "zypper" -> sprintf "zypper -n rm %s" quoted_args | "unknown" -> error_unknown_package_manager (s_"--uninstall") --
Hi Sebastian, On Thursday, 23 August 2018 16:45:27 CEST Sebastian Meyer wrote:
The `-l` option for some `zypper` subcommands is short for `--auto-agree-with-licenses` and not available on the `zypper rm` command.
No problem with the patch, just one question: can it happen that zypper may decide to install packages when removing others, e.g. to keep some other dependency/relationship satisfied? For example: 1) package PkgA depends on PkgB | PkgC 2) when installing PkgA, PkgB is installed 3) you try to remove PkgB, and zypper decides to install PkgC to keep PkgA installed Of course the example above is overly simplified -- though, can the above happen? Thanks, -- Pino Toscano
Hi Pino, On 23.08.2018 17:21, Pino Toscano wrote:
No problem with the patch, just one question: can it happen that zypper may decide to install packages when removing others, e.g. to keep some other dependency/relationship satisfied?
[...] Of course the example above is overly simplified -- though, can the above happen?
I don't think so. If I remove bash for example, it just removes it along with everything that depends on bash. There are some cases where it provides multiple solutions, but in those it just chooses 'cancel' when -n/--non-interactive is set. Regards, -- Sebastian Meyer
On Thursday, 23 August 2018 17:44:21 CEST Sebastian Meyer wrote:
Hi Pino,
On 23.08.2018 17:21, Pino Toscano wrote:
No problem with the patch, just one question: can it happen that zypper may decide to install packages when removing others, e.g. to keep some other dependency/relationship satisfied?
[...] Of course the example above is overly simplified -- though, can the above happen?
I don't think so. If I remove bash for example, it just removes it along with everything that depends on bash.
There are some cases where it provides multiple solutions, but in those it just chooses 'cancel' when -n/--non-interactive is set.
Understood, thanks for the explanation. Your patch LGTM, and I will push it shortly. Thank you for your first contribution! -- Pino Toscano
Hi Pino, On 23.08.2018 17:21, Pino Toscano wrote:
No problem with the patch, just one question: can it happen that zypper may decide to install packages when removing others, e.g. to keep some other dependency/relationship satisfied?
[...] Of course the example above is overly simplified -- though, can the above happen?
I don't think so. If I remove bash for example, it just removes it along with everything that depends on bash. There are some cases where it provides multiple solutions, but in those it just chooses 'cancel' and returns 4 when -n/--non-interactive is set. Regards, -- Sebastian Meyer
participants (2)
-
Pino Toscano -
Sebastian Meyer