Re: [Libguestfs] Hivex licensing question
On Fri, Nov 26, 2010 at 10:03:05AM -0800, Yandell, Henri wrote:
We’re looking into using Hivex and came across something odd. While the license of hivex.c is LGPL 2.1, it appears to require the GPL 3.0 licensed gnulib package for a few minor functions ( full_read, full_write and c_toupper ). There are also a few GPL 3.0 build files.
It has always been our intention to allow hivex to be used from both proprietary and free software, and so the library should be LGPLv2+. The standalone programs are GPLv2+, but this should not be a problem because you wouldn't link software to them. I have looked at the gnulib modules that we're using in the library (ie. lib/*) and they are: hivex c-ctype LGPLv2+ hivex full-read LGPL hivex full-write LGPL (according to .gnulib/modules/* License field which is what you should look at, *not* the comments at the top of each gnulib source file bizarrely). Therefore I think for the library we are OK. Just to complete the analysis, for the programs we are using: hivexsh c-ctype LGPLv2+ hivexsh xstrtol GPL The Makefiles are GPL, but they don't affect the library or the programs in any way. They constitute a separate program used to build the software. Rich. CC'd to Jim: This analysis is a pain, and gnulib-tool doesn't let you say "I want to use LGPL for this directory and GPL for this other directory". -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
Thanks for the very quick reply Richard. I agree that it's bizarre. On the Hivex side, a README in the gnulib directory would be very useful; maybe just copying over the gnulib README file would be enough. I'll take my further confusion over to the bug-gnulib@ mailing list :) Thanks, Hen On 11/26/10 10:22 AM, "Richard W.M. Jones" <rjones@redhat.com> wrote:
On Fri, Nov 26, 2010 at 10:03:05AM -0800, Yandell, Henri wrote:
We¹re looking into using Hivex and came across something odd. While the license of hivex.c is LGPL 2.1, it appears to require the GPL 3.0 licensed gnulib package for a few minor functions ( full_read, full_write and c_toupper ). There are also a few GPL 3.0 build files.
It has always been our intention to allow hivex to be used from both proprietary and free software, and so the library should be LGPLv2+.
The standalone programs are GPLv2+, but this should not be a problem because you wouldn't link software to them.
I have looked at the gnulib modules that we're using in the library (ie. lib/*) and they are:
hivex c-ctype LGPLv2+ hivex full-read LGPL hivex full-write LGPL
(according to .gnulib/modules/* License field which is what you should look at, *not* the comments at the top of each gnulib source file bizarrely).
Therefore I think for the library we are OK.
Just to complete the analysis, for the programs we are using:
hivexsh c-ctype LGPLv2+ hivexsh xstrtol GPL
The Makefiles are GPL, but they don't affect the library or the programs in any way. They constitute a separate program used to build the software.
Rich.
CC'd to Jim: This analysis is a pain, and gnulib-tool doesn't let you say "I want to use LGPL for this directory and GPL for this other directory".
Richard W.M. Jones wrote:
On Fri, Nov 26, 2010 at 10:03:05AM -0800, Yandell, Henri wrote:
We’re looking into using Hivex and came across something odd. While the license of hivex.c is LGPL 2.1, it appears to require the GPL 3.0 licensed gnulib package for a few minor functions ( full_read, full_write and c_toupper ). There are also a few GPL 3.0 build files.
It has always been our intention to allow hivex to be used from both proprietary and free software, and so the library should be LGPLv2+.
The standalone programs are GPLv2+, but this should not be a problem because you wouldn't link software to them.
I have looked at the gnulib modules that we're using in the library (ie. lib/*) and they are:
hivex c-ctype LGPLv2+ hivex full-read LGPL hivex full-write LGPL
(according to .gnulib/modules/* License field which is what you should look at, *not* the comments at the top of each gnulib source file bizarrely).
Therefore I think for the library we are OK.
Just to complete the analysis, for the programs we are using:
hivexsh c-ctype LGPLv2+ hivexsh xstrtol GPL
Hi Rich, Your analysis is correct.
The Makefiles are GPL, but they don't affect the library or the programs in any way. They constitute a separate program used to build the software.
Rich.
CC'd to Jim: This analysis is a pain, and gnulib-tool doesn't let you say "I want to use LGPL for this directory and GPL for this other directory".
Yes, that is inconvenient. The alternative is to have two separate gnulib-style libraries, one with the lgplv2+ modules you use, and another for those additional ones that you use from gplv3 applications. But that is a lot of inconvenience for not much gain. This has been lamented and discussed/justified several times on the bug-gnulib mailing list.
On 11/26/10 10:48 AM, "Jim Meyering" <jim@meyering.net> wrote:
Richard W.M. Jones wrote:
The Makefiles are GPL, but they don't affect the library or the programs in any way. They constitute a separate program used to build the software.
Rich.
CC'd to Jim: This analysis is a pain, and gnulib-tool doesn't let you say "I want to use LGPL for this directory and GPL for this other directory".
Yes, that is inconvenient. The alternative is to have two separate gnulib-style libraries, one with the lgplv2+ modules you use, and another for those additional ones that you use from gplv3 applications. But that is a lot of inconvenience for not much gain.
This has been lamented and discussed/justified several times on the bug-gnulib mailing list.
Taking that as a hint not to go charging off onto bug-gnulib@, and looking at the bug-gnulib archive, Bruno Haible says in http://www.mail-archive.com/bug-gnulib@gnu.org/msg20323.html: "The header is updated automatically when you import the file into your project, assuming you invoke gnulib-tool with the option --lgpl or --lgpl=2." Is this a solution Hivex can use? Hen
On Fri, Nov 26, 2010 at 11:01:53AM -0800, Yandell, Henri wrote:
Taking that as a hint not to go charging off onto bug-gnulib@, and looking at the bug-gnulib archive, Bruno Haible says in http://www.mail-archive.com/bug-gnulib@gnu.org/msg20323.html:
"The header is updated automatically when you import the file into your project, assuming you invoke gnulib-tool with the option --lgpl or --lgpl=2."
Is this a solution Hivex can use?
It's a good idea, but unfortunately because we are using one GPL module[1] we can't use that flag because then gnulib-tool would refuse to run. It's a bit strange that this flag controls two different things: controlling whether to import the module according to the license, AND adding a header to the imported source file. Rich. [1] across the whole package, not in the library. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
Hello Richard,
It's a bit strange that this flag [--lgpl] controls two different things: controlling whether to import the module according to the license, AND adding a header to the imported source file.
It's not strange, it's necessary for consistency. If a package is LGPL, it wants only modules that are compatible with LGPL packaging, and it wants LGPL headers in the source files.
"The header is updated automatically when you import the file into your project, assuming you invoke gnulib-tool with the option --lgpl or --lgpl=2."
Is this a solution Hivex can use?
It's a good idea, but unfortunately because we are using one GPL module[1] we can't use that flag because then gnulib-tool would refuse to run.
[1] across the whole package, not in the library.
In this case, I will soon recommend to run gnulib-tool twice, once for the library, with --lgpl flag, and once for the rest of the package, without --lgpl flag and an option that indicates the other checkout. (This option has recently been suggested by Sam and Gary, but is not yet implemented. Therefore "soon".) This will make it easier for packagers who analyze the license of the package. If there is a module that is GPLed and that _looks_ like it might be used by an LGPLed library, this is enough to confuse the people who do the license bookkeeping. It is easier if one directory has only source code with LGPL header, and another directory has only source code with GPL header. Each of the directories can contain source code from gnulib, but that requires two gnulib-tool invocations. Bruno
Yandell, Henri wrote:
On 11/26/10 10:48 AM, "Jim Meyering" <jim@meyering.net> wrote:
Richard W.M. Jones wrote:
The Makefiles are GPL, but they don't affect the library or the programs in any way. They constitute a separate program used to build the software.
Rich.
CC'd to Jim: This analysis is a pain, and gnulib-tool doesn't let you say "I want to use LGPL for this directory and GPL for this other directory".
Yes, that is inconvenient. The alternative is to have two separate gnulib-style libraries, one with the lgplv2+ modules you use, and another for those additional ones that you use from gplv3 applications. But that is a lot of inconvenience for not much gain.
This has been lamented and discussed/justified several times on the bug-gnulib mailing list.
Taking that as a hint not to go charging off onto bug-gnulib@, and looking at the bug-gnulib archive, Bruno Haible says in http://www.mail-archive.com/bug-gnulib@gnu.org/msg20323.html:
"The header is updated automatically when you import the file into your project, assuming you invoke gnulib-tool with the option --lgpl or --lgpl=2."
Is this a solution Hivex can use?
To use that it would have to run gnulib-tool twice (once with one --lgpl=... option and once with the other), creating two separate library directories, as I suggested above. That's the inconvenience I mentioned. IMHO, it would be prohibitive in a project the size of hivex, at least until/if gnulib-tool ever becomes more efficient.
participants (4)
-
Bruno Haible -
Jim Meyering -
Richard W.M. Jones -
Yandell, Henri