IMHO trailing spaces should be permitted in POD files. Currently they are prevented by the git upload hook. The reason to allow them in POD files is because indentation is used to indicate blocks of preformatted text (the equivalent of <pre> in HTML). To keep code together in the output if it contains blank lines you have to add a line containing a single space. For an example of where this is currently wrong, because we're not allowed to have trailing spaces, see the preformatted code block here: http://libguestfs.org/guestfs.3.html#handles I have no idea how the git hook is implemented or whether we can make it give an exception to POD files. (Jim?) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
Richard W.M. Jones wrote:
IMHO trailing spaces should be permitted in POD files. Currently they are prevented by the git upload hook.
The reason to allow them in POD files is because indentation is used to indicate blocks of preformatted text (the equivalent of <pre> in HTML). To keep code together in the output if it contains blank lines you have to add a line containing a single space.
For an example of where this is currently wrong, because we're not allowed to have trailing spaces, see the preformatted code block here:
http://libguestfs.org/guestfs.3.html#handles
I have no idea how the git hook is implemented or whether we can make it give an exception to POD files. (Jim?)
Hi Rich, Sure, I've just exempted pod files from whitespace checks by doing this on the server: $ cd /git/libguestfs.git && echo '*.pod -whitespace' >> info/attributes
On Fri, Nov 13, 2009 at 04:45:58PM +0100, Jim Meyering wrote:
Sure, I've just exempted pod files from whitespace checks by doing this on the server:
$ cd /git/libguestfs.git && echo '*.pod -whitespace' >> info/attributes
Thanks. I've just made the changes to the POD files: http://git.et.redhat.com/?p=libguestfs.git;a=commitdiff;h=747eb7138ada2c999a... (Docs on the website not updated yet). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html
participants (2)
-
Jim Meyering -
Richard W.M. Jones