A few patches needed for libguestfs 1.20+ on current Debian systems
Here's what I needed to build and run 1.20 on Debian/unstable. Perhaps the libcap2 dependency in the packagelist should only be added if libcap has actually been used in building guestfsd...
--- erlang/run-bindtests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erlang/run-bindtests b/erlang/run-bindtests index 1a6aea5..17db79e 100755 --- a/erlang/run-bindtests +++ b/erlang/run-bindtests @@ -19,5 +19,5 @@ set -e # The output is sent to bindtests.tmp. -./bindtests.erl +$srcdir/bindtests.erl diff -u $srcdir/../bindtests bindtests.tmp -- 1.7.10.4
--- inspector/test-xmllint.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inspector/test-xmllint.sh.in b/inspector/test-xmllint.sh.in index c156bd2..602823f 100755 --- a/inspector/test-xmllint.sh.in +++ b/inspector/test-xmllint.sh.in @@ -25,5 +25,5 @@ if [ -z "$EXAMPLE_XML" ]; then fi for f in $EXAMPLE_XML; do - @XMLLINT@ --noout --relaxng $srcdir/virt-inspector.rng $f + @XMLLINT@ --noout --relaxng $srcdir/virt-inspector.rng $srcdir/$f done -- 1.7.10.4
- ntfsprogs has been merged with ntfs-3g -- and it has been an empty transitional package for some time now. - libyajl is needed for ldm - libcap2 is needed for guestfs --- appliance/packagelist.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 9b0cc09..1afaff9 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -62,14 +62,15 @@ hfsplus iproute libaugeas0 + libcap2 libhivex0 libyajl2 linux-image nilfs-tools ntfs-3g - ntfsprogs openssh-client reiserfsprogs + sysvinit /* for /sbin/reboot */ ufsutils vim-tiny xz-utils -- 1.7.10.4
On Thu, Jan 17, 2013 at 11:59:22PM +0100, Hilko Bengen wrote:
- ntfsprogs has been merged with ntfs-3g -- and it has been an empty transitional package for some time now.
We can leave the empty 'ntfsprogs' package in the package list (even if it gets deleted entirely from Debian) since febootstrap will ignore non-existent packages. It is probably worth leaving it so that people can still compile libguestfs on older versions of Debian. I will add a modified patch with sysvinit. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
On Thu, Jan 17, 2013 at 11:59:19PM +0100, Hilko Bengen wrote:
Here's what I needed to build and run 1.20 on Debian/unstable.
Perhaps the libcap2 dependency in the packagelist should only be added if libcap has actually been used in building guestfsd...
By coincidence Skippy VonDrake just found this bug and I added a patch for it: https://github.com/libguestfs/libguestfs/commit/24c4178749817639ecf9ad61f7de... It's fine to unconditionally list libcap{,2} in appliance/packagelist.in. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
On Thu, Jan 17, 2013 at 11:59:19PM +0100, Hilko Bengen wrote:
Here's what I needed to build and run 1.20 on Debian/unstable.
Perhaps the libcap2 dependency in the packagelist should only be added if libcap has actually been used in building guestfsd...
Ah I see that you mentioned yesterday you'd already found the libcap problem. It's fixed upstream now so thanks! I've pushed all three patches. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
participants (2)
-
Hilko Bengen -
Richard W.M. Jones