[PATCH] Update common submodule (RHBZ#1351000)
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common b/common index c33e0036c70c..12f3fb0f6ccd 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit c33e0036c70ce68d40df92e4a6c0423e136e005c +Subproject commit 12f3fb0f6ccdacb4c6fb81385550b62665fc1497 -- 2.25.1
On Mon, Feb 24, 2020 at 10:23:54AM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common b/common index c33e0036c70c..12f3fb0f6ccd 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit c33e0036c70ce68d40df92e4a6c0423e136e005c +Subproject commit 12f3fb0f6ccdacb4c6fb81385550b62665fc1497
I don't know if there's much point in posting these patches for review. If you have commit access then I believe it's always(?) valid to push an update that takes us to the latest version of libguestfs-common master branch, and if you don't have commit access then ping me or Pino on IRC to do it. But yes this is fine. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
On Mon, Feb 24, 2020 at 09:51:01AM +0000, Richard W.M. Jones wrote:
On Mon, Feb 24, 2020 at 10:23:54AM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common b/common index c33e0036c70c..12f3fb0f6ccd 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit c33e0036c70ce68d40df92e4a6c0423e136e005c +Subproject commit 12f3fb0f6ccdacb4c6fb81385550b62665fc1497
I don't know if there's much point in posting these patches for review. If you have commit access then I believe it's always(?) valid to push an update that takes us to the latest version of libguestfs-common master branch, and if you don't have commit access then ping me or Pino on IRC to do it.
But yes this is fine.
But I don't think I do. That's why I did not push the ACKed patches and asked for someone to do it. Or maybe I have just for this one, let me try... No, I don't. I mean it makes sense, I did not really contribute anything that much (we always ended up doing it differently).
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
On Mon, Feb 24, 2020 at 12:08:30PM +0100, Martin Kletzander wrote:
On Mon, Feb 24, 2020 at 09:51:01AM +0000, Richard W.M. Jones wrote:
On Mon, Feb 24, 2020 at 10:23:54AM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common b/common index c33e0036c70c..12f3fb0f6ccd 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit c33e0036c70ce68d40df92e4a6c0423e136e005c +Subproject commit 12f3fb0f6ccdacb4c6fb81385550b62665fc1497
I don't know if there's much point in posting these patches for review. If you have commit access then I believe it's always(?) valid to push an update that takes us to the latest version of libguestfs-common master branch, and if you don't have commit access then ping me or Pino on IRC to do it.
But yes this is fine.
But I don't think I do. That's why I did not push the ACKed patches and asked for someone to do it. Or maybe I have just for this one, let me try... No, I don't. I mean it makes sense, I did not really contribute anything that much (we always ended up doing it differently).
I've done it now (for both libguestfs & virt-v2v). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
participants (2)
-
Martin Kletzander -
Richard W.M. Jones