[PATCH] ESX: Always validate SSL certificate
Since fetching storage from ESX was split into separate HEAD and GET requests, the SSL certificate has only been validated on the HEAD request. It should be validated on both. --- lib/Sys/VirtV2V/Transfer/ESX.pm | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/Sys/VirtV2V/Transfer/ESX.pm b/lib/Sys/VirtV2V/Transfer/ESX.pm index f638149..5d6b586 100644 --- a/lib/Sys/VirtV2V/Transfer/ESX.pm +++ b/lib/Sys/VirtV2V/Transfer/ESX.pm @@ -143,6 +143,8 @@ sub get_volume my $died = $r->header('X-Died'); die($died) if (defined($died)); + $self->verify_certificate($r) unless ($self->{_v2v_noverify}); + # It reports success even if we didn't receive the whole file die(user_message(__x("Didn't receive full volume. Received {received} ". "of {total} bytes.", -- 1.7.0.1
On Mon, Jun 07, 2010 at 01:32:35PM +0100, Matthew Booth wrote:
Since fetching storage from ESX was split into separate HEAD and GET requests, the SSL certificate has only been validated on the HEAD request. It should be validated on both.
ACK. Meta point: If you include the bug number in all commit messages, then I have written a useful little script (attached) which pulls out a plain text summary of all the bugs which have been fixed between two releases. It's very useful when writing release notes. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
participants (2)
-
Matthew Booth -
Richard W.M. Jones