On Sun, May 19, 2013 at 03:53:37PM +0200, Hilko Bengen wrote: NACK to this version (still ACK to the first version however). I think this change defeats the point of the original error which was to force the user to set the path to something. Also how do we know that @libdir@/guestfs will be an appliance? It seems unlikely to contain anything useful, or it could even contain a different appliance from an installed copy of libguestfs which would be actively wrong. In order to build the virt-sysprep documentation we have to run virt-sysprep (to dump out the table of operations supported by the binary). Specifically it runs: ../run ./virt-sysprep --dump-pod[-options] which are internal flags to get the binary to print out the documentation. An appliance should not be needed for this of course. As you say, this fails at the moment unnecessarily. Your first version of this patch fixed this just fine (apart from printing a harmless warning) and works for me. So I don't understand the need to have the ./run script setting LIBGUESTFS_PATH as in this second version. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top

Otherwise, the test fails with --disable-appliance. --- fish/test-events.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fish/test-events.sh b/fish/test-events.sh index 79957ed..46b644b 100755 --- a/fish/test-events.sh +++ b/fish/test-events.sh @@ -22,6 +22,12 @@ set -e rm -f test.out +# A meaningful LIBGUESTFS_PATH is technically not needed, but the +# "trace get_path" line may not be predictable it it has not been set. +if [ -z "$LIBGUESTFS_PATH" ]; then + export LIBGUESTFS_PATH=/nonexistent +fi + ./guestfish -a /dev/null <<'EOF' | grep -v get_verbose | grep -v get_trace | grep -v 'library .*0x' | grep -v 'library command' > test.out trace true -- 1.7.10.4

The test would fail when LIBGUESTFS_PATH was not set. --- fish/test-events.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fish/test-events.sh b/fish/test-events.sh index 79957ed..d838b98 100755 --- a/fish/test-events.sh +++ b/fish/test-events.sh @@ -22,7 +22,7 @@ set -e rm -f test.out -./guestfish -a /dev/null <<'EOF' | grep -v get_verbose | grep -v get_trace | grep -v 'library .*0x' | grep -v 'library command' > test.out +./guestfish -a /dev/null <<'EOF' | grep -v get_verbose | grep -v get_trace | grep -v 'library .*0x' | grep -v 'library command' | grep -v 'get_path' > test.out trace true event ev1 * "echo $EVENT $@" @@ -61,7 +61,6 @@ trace get_autosync trace get_autosync = 1 enter get_path trace get_path -trace get_path = "'$LIBGUESTFS_PATH'" enter get_pgroup trace get_pgroup trace get_pgroup = 0 -- 1.7.10.4