On Fri, Nov 12, 2021 at 02:50:00PM +0100, Laszlo Ersek wrote:

Hi,

commit b536c61a6df3 ("m4: Remove test for OCaml Bytes module", 2021-11-09) removed AM_CONDITIONAL([HAVE_BYTES_COMPAT_ML ... from "m4/guestfs-ocaml.m4". However, in the common submodule, "mlstdutils/Makefile.am" still contains lines such as:

if HAVE_BYTES_COMPAT_ML

This causes autoreconf in libguestfs to fail with:

Ahhhhh, that's not good. Let me fix that very quickly.

common/mlstdutils/Makefile.am:30: error: HAVE_BYTES_COMPAT_ML does not appear in AM_CONDITIONAL

My libguestfs checkout is current master (commit 4fe8df48a723), with the matching common submodule checkout (62ccce447228).

Substituting a constant for HAVE_BYTES_COMPAT_ML in the "common" submodule is not obviously a solution, as guestfs-tools still has AM_CONDITIONAL([HAVE_BYTES_COMPAT_ML ..., in "configure.ac" (at commit 7fdf82407d36).

For now, so that I can progress with something else, I guess I'll try checking out libguestfs at an earlier commit than b536c61a6df3.

Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v