[PATCH Fedora libguestfs v4] Don't depend on libvirt-daemon-kvm
Compared to v3 this suggests: +Suggests: qemu-block-curl +Suggests: qemu-block-gluster +Suggests: qemu-block-iscsi +Suggests: qemu-block-rbd +Suggests: qemu-block-ssh which I missed in an earlier email from danpb.
libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter. There are no Fedora TCG-only arches, so drop the conditional section. --- libguestfs.spec | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libguestfs.spec b/libguestfs.spec index 0d32ef0..ca2e434 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -211,12 +211,16 @@ Requires: fuse # For core disk-create API. Requires: /usr/bin/qemu-img -# For libvirt backend. -%ifarch %{ix86} x86_64 %{arm} aarch64 -Requires: libvirt-daemon-kvm >= 0.10.2-3 -%else -Requires: libvirt-daemon-qemu >= 0.10.2-3 -%endif +# For qemu direct and libvirt backends. +Requires: qemu-kvm-core +Suggests: qemu-block-curl +Suggests: qemu-block-gluster +Suggests: qemu-block-iscsi +Suggests: qemu-block-rbd +Suggests: qemu-block-ssh +Requires: libvirt-daemon-driver-qemu +Requires: libvirt-daemon-driver-secret +Recommends: libvirt-daemon-driver-storage-core Recommends: libvirt-daemon-config-network Requires: selinux-policy >= 3.11.1-63 -- 2.24.1
On Fri, Jan 10, 2020 at 10:17:02PM +0000, Richard W.M. Jones wrote:
libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter.
There are no Fedora TCG-only arches, so drop the conditional section. --- libguestfs.spec | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/libguestfs.spec b/libguestfs.spec index 0d32ef0..ca2e434 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -211,12 +211,16 @@ Requires: fuse # For core disk-create API. Requires: /usr/bin/qemu-img
-# For libvirt backend. -%ifarch %{ix86} x86_64 %{arm} aarch64 -Requires: libvirt-daemon-kvm >= 0.10.2-3 -%else -Requires: libvirt-daemon-qemu >= 0.10.2-3 -%endif +# For qemu direct and libvirt backends. +Requires: qemu-kvm-core +Suggests: qemu-block-curl +Suggests: qemu-block-gluster +Suggests: qemu-block-iscsi +Suggests: qemu-block-rbd +Suggests: qemu-block-ssh +Requires: libvirt-daemon-driver-qemu +Requires: libvirt-daemon-driver-secret +Recommends: libvirt-daemon-driver-storage-core Recommends: libvirt-daemon-config-network Requires: selinux-policy >= 3.11.1-63
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Daniel P. Berrangé -
Richard W.M. Jones