[PATCH] ruby: add -DGUESTFS_PRIVATE_FUNCTIONS=1 to CFLAGS
Signed-off-by: Olaf Hering <olaf@aepfle.de> --- This, and the CFLAGS change it depends on should be backported to 1.20.x ruby/ext/guestfs/extconf.rb.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ruby/ext/guestfs/extconf.rb.in b/ruby/ext/guestfs/extconf.rb.in index 15259ea..808ff9e 100644 --- a/ruby/ext/guestfs/extconf.rb.in +++ b/ruby/ext/guestfs/extconf.rb.in @@ -30,7 +30,7 @@ unless have_library("guestfs", "guestfs_create", "guestfs.h") end $CFLAGS = - "#{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE_FUNCTIONS=1 " << + "#{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE_FUNCTIONS=1 -DGUESTFS_PRIVATE_FUNCTIONS=1" << "@WARN_CFLAGS@ @WERROR_CFLAGS@" create_header -- 1.8.0.1
On Wed, Jan 02, 2013 at 07:27:54PM +0100, Olaf Hering wrote:
Signed-off-by: Olaf Hering <olaf@aepfle.de> ---
This, and the CFLAGS change it depends on should be backported to 1.20.x
ruby/ext/guestfs/extconf.rb.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ruby/ext/guestfs/extconf.rb.in b/ruby/ext/guestfs/extconf.rb.in index 15259ea..808ff9e 100644 --- a/ruby/ext/guestfs/extconf.rb.in +++ b/ruby/ext/guestfs/extconf.rb.in @@ -30,7 +30,7 @@ unless have_library("guestfs", "guestfs_create", "guestfs.h") end
$CFLAGS = - "#{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE_FUNCTIONS=1 " << + "#{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE_FUNCTIONS=1 -DGUESTFS_PRIVATE_FUNCTIONS=1" << "@WARN_CFLAGS@ @WERROR_CFLAGS@"
I may be missing something, but doesn't this add -DGUESTFS_PRIVATE_FUNCTIONS=1 twice? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
On Thu, Jan 17, Richard W.M. Jones wrote:
On Wed, Jan 02, 2013 at 07:27:54PM +0100, Olaf Hering wrote:
- "#{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE_FUNCTIONS=1 " << + "#{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE_FUNCTIONS=1 -DGUESTFS_PRIVATE_FUNCTIONS=1" << "@WARN_CFLAGS@ @WERROR_CFLAGS@"
I may be missing something, but doesn't this add -DGUESTFS_PRIVATE_FUNCTIONS=1 twice?
Indeed. I will double check whats wrong. Olaf
participants (2)
-
Olaf Hering -
Richard W.M. Jones