Hello Richard,
Haha, ok, here's a good one: I commented that if statement out at line 300, applied your patch (I see you updated the github of this code, perhaps that's the best place to grab the code from), and when I run virt-sysprep, I get the following parameter for my disk drive:
>> qemu-system-x86_64: -drive file=rbd:ibvirt-pool/server-clone-test:mon_host=192.168.0.40\:6789\;192.168.0.35\:6789\;192.168.0.2\:6789:auth_supported=none,cache=writeback,id=hd0,if=none: error opening pool ibvirt-pool
Since "ibvirt-pool" doesn't exist. :)
So this says to me that the function "create_drive_non_file" is consuming that first slash somewhere. Perhaps "safe_strdup"? I'm not sure where "safe_strdup" is to confirm, but it looks like other functions use the "safe_stardup" function.
With that in mind, I didn't want to have to reinvent create_drive_non_file, and without a better understanding of how all the code works together, I came up with a little hack which basically prepends the slash if there isn't one.
if (exportname[0] != '/') {
// char name[(sizeof exportname) + 1];
char name[256];
snprintf(name, sizeof name, "/%s", exportname);
exportname = name;
}
My concern is long rbd-pool/rbd names, hence the commented out line, but that causes the name of the disk to be:
>> qemu-system-x86_64: -drive file=rbd:libvirt:mon_host=192.168.0.40\:6789\;192.168.0.35\:6789\;192.168.0.2\:6789:auth_supported=none,cache=writeback,id=hd0,if=none: could not open disk image rbd:libvirt:mon_host=192.168.0.40\:6789\;192.168.0.35\:6789\;192.168.0.2\:6789:auth_supported=none: Invalid argument
For some reason, the commented out line in the if statement above is truncating the end of the name. Admittedly, my C skills are a bit rusty, so I'm probably overlooking something obvious.