On Thu, Mar 29, 2018 at 05:26:13PM +0200, Piotr Kliczewski wrote:
> Richard,
>
> Great progress. I really like it!!!
>
> Here is what I noticed:
>
> I see that in the yaml file we provide short-id as:
>
> os:
> osinfo: 'rhel7.2'
>
> whereas kubevirt expects it in metadata:
>
> metadata:
> labels:
> kubevirt.io/os: win10
>
> For windows vms we need to create perset like this one [1]. We can add
> separator
>
> ---
>
> between the objects.
I'm a bit confused about the second part. Is the VirtualMachinePreset
file a separate file from the .yaml file that we're creating already
or is it a replacement for it?
We can create as many files as needed, or create different files
depending on the machine type, or whatever is needed.
Sorry for not being clear enough. It can be single file with separator as i mentioned above. For windows we need 2 objects in the file for rhel just one.
Anyway I was hoping you'd take this patch and run with it. Certainly
the osinfo part (which I just made up on the spot) is dead simple to
change. You can post patches on this mailing list (eg. using ‘git
send-email’) and we can review them together.
Yeah, this is the missing part. I like your approach is much better. Thank you!