On Thu, Mar 29, 2018 at 5:26 PM, Piotr Kliczewski <pkliczew@redhat.com> wrote:

Richard,

Great progress. I really like it!!!

That's crazy, Rich! :)

And actually pretty straight forward … to read.

Here is what I noticed:

I see that in the yaml file we provide short-id as:

os:
osinfo: 'rhel7.2'

whereas kubevirt expects it in metadata:

metadata:
labels:
kubevirt.io/os: win10

Yes, such a label is needed - The value should be the libosinfo OS short-id.

For windows vms we need to create perset like this one [1]. We can add separator

We need to see how this evolves.

I'd aim at saing that KubeVirt will provide - as part of it's releases - presets for a given set of short-ids.

Then a client - like v2v - can assume - or knows - for which OSses presets exist and can just reference them.

Really cool.

- fabian

---
between the objects.
Thanks,
Piotr

[1] https://github.com/kubevirt/kubevirt/blob/master/manifests/release/demo-content.yaml.in
On Tue, Mar 27, 2018 at 6:31 PM, Richard W.M. Jones <rjones@redhat.com> wrote:
Fixes some of the more egregious problems with v1, and also
applies properly to the head of git without needing any other
patches.

Rich.