On Tue, Jul 24, 2018 at 7:16 PM Daniel Erez <derez@redhat.com> wrote:
Search for DC by 'storage.name=' to make it explicit.
I.e. "storage=" uses regex, so similar names can be
found in the search query. For example, searching for
a domain named FCSD, will find FCSD1 as well.
---
 v2v/rhv-upload-plugin.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
index c72f5e181..c6ba1962f 100644
--- a/v2v/rhv-upload-plugin.py
+++ b/v2v/rhv-upload-plugin.py
@@ -70,7 +70,7 @@ def find_host(connection):
     system_service = connection.system_service()
     storage_name = params['output_storage']
     data_centers = system_service.data_centers_service().list(
-        search='storage=%s' % storage_name,
+        search='storage.name=%s' % storage_name,

Looks good, but
 
         case_sensitive=False,
     )
     if len(data_centers) == 0:

We need to be more defensive here.

We expect exactly one result.
len == 0 means there there is no dc with this name (impossible?)
len > 1 means we have a bug - we need to log a detailed error message and return None.

Nir