Re: [Libguestfs] [PATCH 2/2] builder: complete architecture handling
On Tue, Mar 11, 2014 at 04:59:19PM +0100, Pino Toscano wrote:
+let arch_is_compatible nativearch otherarch =
+ let nativearch = filter_arch nativearch in
+ let otherarch = filter_arch otherarch in
+ match nativearch, otherarch with
+ | a, b when a = b -> true
+ | "x86_64", "i386" -> true
+ | "ppc64", "ppc" -> true
+ | "sparc64", "sparc" -> true
+ | a, b -> false
It's likely that you can add:
| "aarch64", arch when string_prefix arch "arm" -> true
The aarch64 guys were talking about dropping 32 bit compatibility, but
my prediction is that will never happen.
-val cache_of_name : string -> string -> int -> string
+val cache_of_name : string -> string -> string -> int -> string
(** [cache_of_name cachedir name revision] returns the filename
^
add arch here
Rest looks fine, ACK.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v