On Sun, Oct 31, 2021 at 06:20:05PM +0000, Richard W.M. Jones wrote:
> On Sun, Oct 31, 2021 at 06:59:32PM +0200, Nir Soffer wrote:
> > Having different license for the tests complicates everyone life for no
> > benefit. Change the license to LGPL2+ like the rest of the library.
> >
> > Related discussion:
> > https://listman.redhat.com/archives/libguestfs/2021-October/msg00196.html
> >
> > Signed-off-by: Nir Soffer <nsoffer@redhat.com>
>
> I agree with this change.
>
> Since this involves some code that I wrote originally, can you add:
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
>
> However I'm not the only author here (by quite a lot!):
>
> $ git shortlog -s golang/src/libguestfs.org/libnbd/
> 13 Eric Blake
> 2 Nir Soffer
> 4 Richard W.M. Jones
>
> so could be a good idea to ask Eric specifically for permission too
> (even though in both cases the © is likely assigned to Red Hat as our
> employer).
For the avoidance of any doubt, I'm also okay with this change, and
would prefer you add:
Signed-off-by: Eric Blake <eblake@redhat.com>
Thanks, I will add signed-of-by for you and Richard, and push the version
with fixed makefile.